Add three-tier demo SP and Kind run docs#29
Conversation
gciavarrini
requested review from
ebichman-1,
gabriel-farache,
jenniferubah,
machacekondra and
ygalblum
as code owners
ygalblum
left a comment
ygalblum
left a comment
There was a problem hiding this comment.
General comment, should we use the CLI instead of curl calls? Again, not a must
| # K8S_CONTAINER_SP_EXTERNAL_SVC_TYPE=NodePort | ||
|
|
||
| # Three-tier demo app service provider (profile: three-tier) | ||
| # Kubeconfig: use K8S_CONTAINER_SP_KUBECONFIG. |
There was a problem hiding this comment.
THREE_TIER_SP_NAMESPACE should follow the same as it must be the same
|
|
||
| ```bash | ||
| export THREE_TIER_SP_NAME=my-provider | ||
| export THREE_TIER_SP_NAMESPACE=default |
There was a problem hiding this comment.
As mentioned in .env.example the namespace must match the one used for the container service
| "policy_type": "GLOBAL", | ||
| "enabled": true, | ||
| "priority": 100, | ||
| "rego_code": "package policies.three_tier_default\n\nmain := {\n \"rejected\": false,\n \"selected_provider\": \"three-tier-provider\"\n}\n" |
There was a problem hiding this comment.
Not a must, but maybe check the payload to see that it points to the pet-clinic catalog item (in it's catalog_item_id field). This will allow using this policy also when other policies are used for other service types
That's a nice idea, I added instruction for using the CLI too. See line 64-132 I think the curl commands may be useful for inspecting issue or developement, we can remove that section in a follow up PR if needed. Does it make sense? |
|
FYI @ygalblum and @machacekondra I know there are conflicts, once the PR is approved I'll take care of them :) |
ygalblum
left a comment
ygalblum
left a comment
There was a problem hiding this comment.
Small nit. Not blocking
|
|
||
| ```bash | ||
| curl -s http://localhost:9080/api/v1alpha1/health/providers | jq . | ||
| curl -s http://localhost:9080/api/v1alpha1/providers | jq '.providers[] | {name, health_status}' |
There was a problem hiding this comment.
You can use the CLI for this one as well
Create the three-tier-sp database in init SQL and register the three-tier-demo-service-provider in compose. Assisted-by: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Assisted-by: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Assisted-by: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Assisted-by: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
gciavarrini
force-pushed
the
add-three-tier-app
branch
from
feaa688 to
6ba1f1c
Compare
How would then users enjoy our amazing feature AEP? :)) |
4 participants
Adds the three-tier demo service provider to the Compose and documents how to run it in a Kind cluster.
Based on @ebichman-1 work in #26 — thanks for the initial push.