Skip to content

feat(ci): add Molecule tests, commit hygiene, and compose alignment checks#2

Merged
chadcrum merged 1 commit into
dcm-project:mainfrom
chadcrum:flpath-4172-quadlet-deploy-ci
May 11, 2026
Merged

feat(ci): add Molecule tests, commit hygiene, and compose alignment checks#2
chadcrum merged 1 commit into
dcm-project:mainfrom
chadcrum:flpath-4172-quadlet-deploy-ci

Conversation

@chadcrum
Copy link
Copy Markdown
Contributor

@chadcrum chadcrum commented May 8, 2026

Adds three CI enhancements to the quadlet deploy pipeline:

  • Commit hygienecheck-clean-commits job via shared workflow catches merge commits, fixup/WIP markers, vague messages
  • Molecule template tests — delegated-driver scenario that renders all quadlet templates locally and asserts naming conventions, dependency symmetry, SELinux suffixes, Pull policy, and network membership
  • Compose alignment checks — extends verify_compose_alignment.yml beyond file existence to detect env var drift, dependency ordering mismatches, port mapping differences, and image name divergence

FLPATH-4172

Copy link
Copy Markdown

@testetson22 testetson22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, non-blocking, thing that I'm not entirely sure on, but do we want to version pin ansible-core? Otherwise looks good!

Comment thread molecule/default/verify.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread CLAUDE.md
Comment thread verify_compose_alignment.yml
Comment thread verify_compose_alignment.yml
Comment thread verify_compose_alignment.yml
Comment thread verify_compose_alignment.yml Outdated
Comment thread .github/workflows/ci.yml
Comment thread .yamllint Outdated
Comment thread verify_compose_alignment.yml Outdated
@chadcrum
Copy link
Copy Markdown
Contributor Author

@testetson22 re: pinning ansible-core — done in b994306, pinned to >=2.15 across all CI jobs (aligned with the min_ansible_version in meta/main.yml).

Copy link
Copy Markdown

@gciavarrini gciavarrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…hecks

- Add check-clean-commits shared workflow for commit hygiene
- Add Molecule default scenario with delegated driver for template rendering tests
  (20 assertions: naming, dependency symmetry, SELinux, Pull policy, env, network)
- Extend verify_compose_alignment.yml from 3 to 7 phases (env var coverage,
  dependency ordering, port mapping, image alignment)
- Add yamllint, ansible-lint, syntax-check, and alignment CI jobs
- Pin ansible-core>=2.15, molecule 26.x, Python 3.13
- Use to_json/from_json for reliable Jinja list round-tripping
- Shallow clone api-gateway with depth=1
- Pre-flight assertion for service_to_template mappings

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Chad Crum <chadcrum@users.noreply.github.com>
@chadcrum chadcrum force-pushed the flpath-4172-quadlet-deploy-ci branch from 1f530d8 to d02a75e Compare May 11, 2026 19:29
@chadcrum chadcrum merged commit bcf0eb5 into dcm-project:main May 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants