[codex] Polish watchlist skill guardrails#11
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the watchlist-md skill and its documentation to clarify field requirements, timezone precedence for ID generation, and safety policies regarding sensitive links. Key changes include the addition of the --strict-safety flag documentation, refined validator rules for open items, and updated test cases to verify these guidelines. Feedback suggests improving consistency between the skill definition and the READMEs by explicitly listing all required fields and using precise field names like done_when instead of descriptive labels.
de864b2 to
3ea8f30
Compare
3ea8f30 to
63dd629
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
due_atwording, and timezone precedence in runtime and lifecycle docs.SKILL.mdAdd section while preserving the guardrails; Add section is now 249 words and the body is 745 words.Validation
python3 -m unittest discover -s evals -p 'test_*.py'— 72 tests OKpython3 evals/check_release_metadata.py— passedpython3 evals/check_policy_markers.py— passedpython3 evals/check_semantic_cases.py— 23 cases passedpython3 evals/check_watchlist.py examples/WATCHLIST.example.md --strict-format --strict-safety --require-archive-section— passedpython3 evals/check_watchlist.py .agents/skills/watchlist-md/assets/WATCHLIST.template.md --strict-format --strict-safety --require-archive-section— passedpython3 .agents/skills/watchlist-md/scripts/validate_watchlist.py .agents/skills/watchlist-md/assets/WATCHLIST.template.md --strict-format --strict-safety --require-archive-section— passedgit diff --check origin/main...HEAD— passed