Fix image wrapping logic and regex#2
Open
ddegner wants to merge 2 commits into
Open
Conversation
…nd picture tags Co-authored-by: dingoes-51.slots <dingoes-51.slots@icloud.com>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: dingoes-51.slots <dingoes-51.slots@icloud.com>
ddegner
marked this pull request as ready for review
August 11, 2025 19:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
wrapContentImages()to correctly process images with query strings and avoid skipping valid<img>tags due to unrelated<picture>or AVIF content.The original
wrapContentImages()function had a global early-return that prevented any image wrapping if the content contained<picture>ortype="image/avif". This meant that even plain<img>tags would not be processed if these elements were present elsewhere. Additionally, the regex used to find<img>tags did not account for query strings after the file extension, causing images likeimage.jpg?ver=123to be missed. This PR addresses both issues by removing the global early-return, processing all<img>tags while skipping only those already nested within a<picture>, and updating the regex to correctly match URLs with query strings. It also ensuresavifUrlFor()handles query strings correctly.