loosen requirements#137
Conversation
|
|
||
| # We support PostgreSQL, MySQL, and SQLite | ||
| # Change "sqlite" to "postgresql" or "mysql" if you'd like to use those | ||
| pip install -r requirements/sql/requirements-sqlite.txt |
There was a problem hiding this comment.
Isn't there a way to do something like "pip install aidb[sqlite, mysql]" or whatever?
| from detectron2.config import get_cfg | ||
| try: | ||
| import pdf2image | ||
| except ImportError: |
There was a problem hiding this comment.
I think we should error and tell the user to install instead of installing on their behalf
| scipy==1.10.1 | ||
| six==1.16.0 | ||
| sniffio==1.3.0 | ||
| nest-asyncio>=1.5.7 |
There was a problem hiding this comment.
See above to check if there's a way to consolidate these somehow...
There was a problem hiding this comment.
Hi @ddkang , we can consolidate these required dependencies with the extra optional dependencies into a single requirements file while still maintaining the on-demand installation behavior. We can separate them into sections with '--extra'.
Can you please confirm if that is what we need here?
There was a problem hiding this comment.
@shubhankarunhale You can do that and check if it works for Python 3.12
There was a problem hiding this comment.
Okay, sure. Checking if it works with Python 3.12 for compatible libraries
|
@shubhankarunhale can you help resolve this? |
Sure, looking into it! |
4 participants
might be a better idea to auto pip install (run pip install in python) instead of creating multiple requirements.txt
close #123