Skip to content

several fixes applied#6

Open
alpham8 wants to merge 1 commit into
ddtraceweb:masterfrom
alpham8:several-fixes
Open

several fixes applied#6
alpham8 wants to merge 1 commit into
ddtraceweb:masterfrom
alpham8:several-fixes

Conversation

@alpham8

@alpham8 alpham8 commented May 1, 2018

Copy link
Copy Markdown

Hi,

I fixed the following things:

  • pattern fix (was not working with dash in channel name)
  • removed reference, because it is already an object and it would anyway return a reference, so you don't need a second reference
  • added getters and setters for dependency injection
  • removed reading of empty lines from log file
  • removed last line reading in readme, because it is an iterator and you iterate over all elements

All tests passed.

Hope this helps :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant