fix: trigger docker and pypi builds on tag push instead of release event#49
Merged
fix: trigger docker and pypi builds on tag push instead of release event#49
Conversation
GitHub Actions does not fire workflow events for actions taken by GITHUB_TOKEN. Since release-please uses GITHUB_TOKEN to create the release, the release:published event is suppressed and docker/pypi workflows never run. Switch both to push:tags:v*.*.* which is a real push event that always triggers.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
docker.yamlandpublish.yamlwere triggering onrelease: published, but GitHub suppresses workflow events fired byGITHUB_TOKEN. Since release-please usesGITHUB_TOKENto create the release, therelease: publishedevent never reaches other workflows — so the Docker image and PyPI package were never built on release.Fix
Switch both workflows to trigger on
push: tags: v*.*.*. Release-please pushes the git tag directly (a real push event), which always triggers downstream workflows regardless of the token used.Flow after this fix