Skip to content

fix(e2e): observe generation through stable body - #18

Merged
vriesd merged 3 commits into
mainfrom
release/v0.7.21-recovery
Jul 21, 2026
Merged

fix(e2e): observe generation through stable body#18
vriesd merged 3 commits into
mainfrom
release/v0.7.21-recovery

Conversation

@vriesd

@vriesd vriesd commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • capture the stable document body before deterministic provider streaming starts
  • poll that existing element for the expected heading, generated case, and completion status
  • avoid a fresh selector lookup while the Tauri service and WebView are processing generation events
  • retain the original 15-second completion budget and strict cancellation checks

Root cause

Failed Linux runs captured screenshots containing every expected value, but the new post-generation selector lookup did not complete before the assertion deadline. A timeout increase to 30 seconds reproduced the same failure, and an explicit Tauri window switch caused additional cross-platform direct-eval failures. Polling the pre-existing body avoids that unstable lookup while preserving all product assertions.

Validation

  • targeted generation/cancellation built-app E2E passed locally in 2.9 seconds
  • production E2E isolation passed
  • release metadata for v0.7.21 passed
  • code-size and diff checks passed

Failed evidence runs:

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The generation-cancellation end-to-end workflow now waits up to 30 seconds for the generated test cases element, increased from 15 seconds.

Changes

Generation cancellation workflow

Layer / File(s) Summary
Generated test cases wait timeout
e2e/specs/critical-workflows.e2e.mjs
Increases the generated.waitForDisplayed timeout from 15,000ms to 30,000ms.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: vriesdcrv

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is related to the e2e generation/cancellation timeout fix, though it is a bit more abstract than the code change.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/v0.7.21-recovery

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vriesd vriesd changed the title fix(e2e): tolerate loaded release runners fix(e2e): pin WDIO to the main window Jul 21, 2026
@vriesd vriesd changed the title fix(e2e): pin WDIO to the main window fix(e2e): observe generation through stable body Jul 21, 2026
@vriesd
vriesd merged commit c2a2833 into main Jul 21, 2026
7 checks passed
@vriesd
vriesd deleted the release/v0.7.21-recovery branch July 21, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants