fix(e2e): observe generation through stable body - #18
Merged
Conversation
📝 WalkthroughWalkthroughThe generation-cancellation end-to-end workflow now waits up to 30 seconds for the generated test cases element, increased from 15 seconds. ChangesGeneration cancellation workflow
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Failed Linux runs captured screenshots containing every expected value, but the new post-generation selector lookup did not complete before the assertion deadline. A timeout increase to 30 seconds reproduced the same failure, and an explicit Tauri window switch caused additional cross-platform direct-eval failures. Polling the pre-existing body avoids that unstable lookup while preserving all product assertions.
Validation
Failed evidence runs: