Milestone Four - #10
Merged
Merged
Conversation
…till needs manual verification and testing
…ma header gets generated to use cyclus -n
This was referenced Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings Cypher’s generated XML closer to conventional Cyclus inputs by adding Cyclus grammar-header support and expanding the top-level Control block. Discovery now records base schema provenance, runs cyclus -n to generate the full environment-specific Relax NG schema, caches that schema, and uses it by default for XML xml-model headers. Users can still opt out with schema_path=None or override the schema path explicitly.
This PR also adds table-driven scalar control fields beyond duration, start_year, and start_month, including simhandle, decay, dt, explicit inventory flags, tolerances, seed, and stride. Optional values serialize only when explicitly supplied, control XML stays deterministic and grammar-ordered, and invalid scalar assignments fail before export. The container was also tightened so the notebook verifier catches Matplotlib plotting regressions inside the registered Python (Cypher) kernel.