Nested types - #16
Merged
Merged
Conversation
…ons to describe complex data types and how they need to be input. Also fixed streaming going one character at a time.
…nd-trip that discoveres nested types
…tests creating loopholes for failing tests
…y or may not match what's allowed to representing what's allowed/needed
…alidation and final xml writing the validation step that happens right before xml writing doesn't catch it.
…at not quite matching
This was referenced Aug 24, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a previous issue where nested data types in Cyclus didn't get correctly processed by Cypher (meaning if you wanted something like separations or mixer you were out of luck entirely). This has been fixed.
There was also an issue with the way that Cypher streamed the cyclus output to the terminal which has been fixed as well (it used to go like 1 character at a time and it was really hard to read)
Finally, a bunch of helper functions were added to the class-generation process that describe exactly how to write out the inputs for all the variables.
Passed autonuke review.