fix(safe-delete): file-existence check + expanded rm deny patterns#74
Merged
fix(safe-delete): file-existence check + expanded rm deny patterns#74
Conversation
The trash command errors noisily when a file doesn't exist, unlike rm -f which is silent. Add existence filtering (including broken symlinks) to bash/zsh, fish, and PowerShell Unix blocks before calling trash. Expand the managed-settings deny list to cover rm -r, rm -fr, and rm -f flag variations that could bypass the existing rm -rf-only patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trashin bash/zsh, fish, and PowerShell Unix blocks — prevents noisy errors liketrash: index.lock doesn't existwhenrm -fis used on missing files (e.g.,rm -f .git/index.lock). Handles broken symlinks via[ -L "$f" ]. PowerShell Windows already had this viaResolve-Path.rm -r,rm -fr, andrm -fflag variations to managed-settings deny patterns — closes bypass gap where onlyrm -rfwas blocked (21 rm patterns, up from 8).Test plan
npm run buildpassesnpm test— 169/169 passrm nonexistent-filein terminal after reinstall — should silently no-oprm existing-file— should move to trash as before