config sycall replace#107
Conversation
deathbyknowledge
force-pushed
the
config-sycall-replace
branch
from
f2eac45 to
a840ff3
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2eac451ae
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
deathbyknowledge
force-pushed
the
config-sycall-replace
branch
from
a840ff3 to
c53e002
Compare
|
@codex review |
1 similar comment
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c53e002eaf
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review only considering brand new deployments |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c53e002eaf
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
deathbyknowledge
force-pushed
the
config-sycall-replace
branch
from
c53e002 to
094daf4
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 094daf4d7c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
deathbyknowledge
force-pushed
the
config-sycall-replace
branch
from
094daf4 to
dd61eac
Compare
|
@codex review only into account brand new deployments |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd61eac87e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
| assertVirtualMode(this.identity, meta, WRITE_BIT, key); | ||
|
|
||
| const value = content.trim(); |
There was a problem hiding this comment.
When editing multiline config files such as /sys/config/ai/context.d/*.md on a fresh deployment, this trims leading and trailing whitespace before persisting the value, so an indented first line/code block or intentional trailing blank line in a system prompt is silently changed. The new filesystem-backed config path should preserve file contents exactly and only use a trimmed copy for the blank-user-override deletion check.
Useful? React with 👍 / 👎.
deathbyknowledge
force-pushed
the
config-sycall-replace
branch
from
dd61eac to
fc7678f
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc7678f52a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| return { | ||
| uid: user.uid, | ||
| gid: packageAccessGroup ?? user.gid, |
There was a problem hiding this comment.
For accounts created before the UPG migration, passwd.gid can still be the shared users group (gid 100). This new metadata calculation then gives /sys/users/<legacy uid>/* mode 0660/0770 with gid 100, and because ensureKernelBootstrapped no longer runs the migration, any other member of the shared users group can pass the group-bit check and read/write that legacy user's config. Keep migrating legacy accounts or avoid falling back to a shared primary gid for user config permissions.
Useful? React with 👍 / 👎.
deathbyknowledge
force-pushed
the
config-sycall-replace
branch
from
fc7678f to
741332a
Compare
deathbyknowledge
force-pushed
the
config-sycall-replace
branch
from
741332a to
fcbacce
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fcbacce412
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| gid: packageAccessGroup ?? user.gid, | ||
| mode: userConfigMode(kind, readOnly), |
There was a problem hiding this comment.
Using user.gid for /sys/users/{uid} permissions is unsafe for legacy human accounts because this commit also removes the bootstrap migration that moved old accounts off the shared users group (gid 100). In an upgraded deployment where Bob still has primary gid 100 and Alice is a member of that group, these 0660/0770 modes let Alice read and write Bob's user config, including users/{uid}/ai/api_key, even though new accounts use gid=uid.
Useful? React with 👍 / 👎.
1 participant
No description provided.