fix(richtext): create break nodes on shift + enter#7817
Open
delucis wants to merge 1 commit into
Open
Conversation
yanthomasdev
approved these changes
May 19, 2026
Contributor
yanthomasdev
left a comment
yanthomasdev
left a comment
There was a problem hiding this comment.
LGTM, Thanks @delucis!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inserts break elements on shift + enter in
richtextwidget, matching how themarkdownwidget works.Closes #7816
I referred to the
ExtendedBlockquotePluginwhich has a similar design and the oldLineBreakmethod from themarkdownwidget. Happy to adjust the approach if there’s a better one as this was my first time figuring out Plate and am not familiar with best practices etc.Test plan
Tested in a local project with a patch. I didn’t see tests for other plugins, so wasn’t sure if I should/how to implement testing for this.
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)