Skip to content
This repository was archived by the owner on Jun 1, 2026. It is now read-only.

chore: remove forced alphatest from srp batching helper#5681

Merged
pravusjif merged 2 commits into
devfrom
chore/srp-batching-helper-remove-forced-alphatest
Sep 6, 2023
Merged

chore: remove forced alphatest from srp batching helper#5681
pravusjif merged 2 commits into
devfrom
chore/srp-batching-helper-remove-forced-alphatest

Conversation

@pravusjif

@pravusjif pravusjif commented Sep 5, 2023

Copy link
Copy Markdown
Member

Updated shared-dependencies package used to point to the implementation branch.

This was done to tackle the rendering problem found since unity 2022.3.6f1.


TESTING

We need this PR tested as thoroughly as an RC.

Including:

  • Full RC testing
  • Rendering issue not happening anymore in the onboarding world
  • Testing new user onboarding
  • Testing some popular scenes behaviour to see they keep working as in production

@pravusjif pravusjif self-assigned this Sep 5, 2023
@pravusjif

Copy link
Copy Markdown
Member Author

If this PR is approved for merging, I'll first merge the shared-dependencies PR and then I'll update the commit consumed in UPM in this branch.

@pravusjif pravusjif requested a review from Kinerius September 5, 2023 19:00
@pravusjif pravusjif marked this pull request as ready for review September 5, 2023 19:00
@pravusjif pravusjif added the do not merge This PR should not be merged because is experimental or for testing purposes. label Sep 5, 2023

@anicalbano anicalbano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Reviewed and approved by QA

@pravusjif pravusjif merged commit f6df21e into dev Sep 6, 2023
@pravusjif pravusjif deleted the chore/srp-batching-helper-remove-forced-alphatest branch September 6, 2023 14:12
@pravusjif pravusjif removed the do not merge This PR should not be merged because is experimental or for testing purposes. label Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants