Skip to content
This repository was archived by the owner on Jun 1, 2026. It is now read-only.

Cleanup empty scenes build#6176

Open
ProteanCoding wants to merge 4 commits into
decentraland:devfrom
ProteanCoding:chore/cleanup-empty-scenes-build
Open

Cleanup empty scenes build#6176
ProteanCoding wants to merge 4 commits into
decentraland:devfrom
ProteanCoding:chore/cleanup-empty-scenes-build

Conversation

@ProteanCoding

Copy link
Copy Markdown

What does this PR change?

Removal from the repository of the temporary Empty Scenes build files.

@ProteanCoding ProteanCoding changed the title Chore/cleanup empty scenes build Cleanup empty scenes build Apr 18, 2024
npm-debug.log
.DS_Store
static/dist
public/systems

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This folder is no longer present

@ProteanCoding ProteanCoding marked this pull request as ready for review April 18, 2024 17:37
@aixaCode

Copy link
Copy Markdown
Contributor

How are you testing those changes? You would need to provide a bit more context why are you proposing this change
As far as I understand those empty scenes are still used, and you can't remove them

@ProteanCoding

ProteanCoding commented Apr 19, 2024

Copy link
Copy Markdown
Author

This is meant as a follow-up to #6175.
The empty-scenes are created during the build process.
The temporary files removed in this PR appear to have been left-over from a previous build (and are therefore stale !)

.DS_Store
static/dist
public/systems
public/empty-scenes/common/contents

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ends up containing what are in fact temporary build files.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants