Skip to content

Fix import table handling for older PE formats #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HarryR wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix import table handling for older PE formats #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/loader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,11 @@ bool wibo::Executable::resolveImports() {
while (dir->name) {
char *dllName = fromRVA<char>(dir->name);
DEBUG_LOG("DLL Name: %s\n", dllName);
uint32_t *lookupTable = fromRVA<uint32_t>(dir->importLookupTable);

// Older PEs (NT 3.5-era) omit the ILT and only ship the IAT, which
// on disk holds the hint/name RVAs that later get overwritten.
uint32_t iltRVA = dir->importLookupTable ? dir->importLookupTable : dir->importAddressTable;
uint32_t *lookupTable = fromRVA<uint32_t>(iltRVA);
uint32_t *addressTable = fromRVA<uint32_t>(dir->importAddressTable);

ModuleInfo *module = loadModule(dllName);
Expand Down
Loading