files: normalize Windows trailing-dot filename convention in pathFromWindows#118
Open
HarryR wants to merge 1 commit intodecompals:mainfrom
Open
files: normalize Windows trailing-dot filename convention in pathFromWindows#118HarryR wants to merge 1 commit intodecompals:mainfrom
HarryR wants to merge 1 commit intodecompals:mainfrom
Conversation
…Windows
Windows treats "foo." and "foo" as the same filename — the trailing dot
means "no extension". NT-era tools rely on this equivalence in two
notable places we hit:
1. NMAKE's @<< inline response-file machinery generates temp file
names like "nm12345." (with the trailing dot = no extension).
When LINK.EXE opens the response file, it passes that exact
literal path back through wibo's file layer.
2. NT build infrastructure (e.g. OAK/BIN/makefile.def) has
!INCLUDE .\sources. directives that only work under the same
trailing-dot equivalence.
Without normalization, wibo's case-insensitive path fallback compares
"nm12345." character-by-character against "nm12345" on disk and fails.
Strip trailing dots from each path component (preserving "." and "..")
before the existence check and the case-insensitive walk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows treats "foo." and "foo" as the same filename — the trailing dot means "no extension". NT-era tools rely on this equivalence in two notable places we hit:
NMAKE's @<< inline response-file machinery generates temp file names like "nm12345." (with the trailing dot = no extension). When LINK.EXE opens the response file, it passes that exact literal path back through wibo's file layer.
NT build infrastructure (e.g. OAK/BIN/makefile.def) has !INCLUDE .\sources. directives that only work under the same trailing-dot equivalence.
Without normalization, wibo's case-insensitive path fallback compares "nm12345." character-by-character against "nm12345" on disk and fails. Strip trailing dots from each path component (preserving "." and "..") before the existence check and the case-insensitive walk.