Correct the minimum Rust version - #981
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Raises the declared minimum Rust version from 1.85 to 1.88, updates the installation text and changelog, and adds a CI job that checks the workspace with Rust 1.88.0.
It also applies the mechanical Clippy cleanups that become active once the declared MSRV includes let chains and
is_multiple_of.Why this way
The released v0.2.11 source uses let chains in the parser and resolver. A real build with Rust 1.87 fails at those sites with E0658, while Rust 1.88 builds the workspace and runs the MCP server. Keeping an exact 1.88 CI job makes the metadata an enforced boundary instead of an untested claim.
What it still does not do
This does not change the Deed language or generated programs. It corrects the Rust toolchain required to build the implementation.
Checks
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo check --workspace --lockedin a Rust 1.88.0 Linux containerrust-versioninstead of reaching E0658uvx --from actionlint-py actionlint .github/workflows/ci.ymlgit diff --check