Skip to content

fix: use distinct critcmp group names for PR benchmark comparison #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepjoy merged 1 commit into from
Mar 22, 2026
Merged

fix: use distinct critcmp group names for PR benchmark comparison #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,9 @@ jobs:
echo "::warning::No benchmark baseline found. Merge to main to generate one."
exit 0
fi
# Import the cached baseline under the name "main" so critcmp
# can distinguish the two groups and produce a side-by-side comparison.
critcmp --import baseline.json --name main
critcmp --export current > pr.json
echo 'result<<EOF' >> $GITHUB_OUTPUT
critcmp main current >> $GITHUB_OUTPUT
critcmp baseline.json pr.json >> $GITHUB_OUTPUT
echo 'EOF' >> $GITHUB_OUTPUT

- name: Find existing comment
Expand Down
Loading