refactor!: consolidate migrations from 9 chronological files into 4 object-oriented files#76
Merged
Conversation
…ted files Collapse all ALTER TABLE additions (label, net IO, groups, TTL, scheduling, dependencies, retries, memo) into the CREATE TABLE definitions, eliminating every ALTER statement. New layout: 001_tasks.sql – tasks table + 6 indexes 002_task_history.sql – task_history table + 5 indexes 003_task_deps.sql – task_deps table + 1 index 004_task_tags.sql – task_tags & task_history_tags + 2 indexes BREAKING CHANGE: existing databases must be recreated (pre-1.0).
Contributor
Benchmark ComparisonClick to expand |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tasks,task_history,task_deps, andtask_tags/task_history_tagsALTER TABLE ADD COLUMNstatements (label, net IO, groups, TTL, scheduling, dependencies, retries, memo) into their respectiveCREATE TABLEdefinitions, eliminating every ALTER statementmigrate()instore/mod.rs— all migrations now use idempotentCREATE TABLE/INDEX IF NOT EXISTS, removing therun_alter_migrationhelperNew migration layout
001_tasks.sqltasks(32 cols)002_task_history.sqltask_history(30 cols)003_task_deps.sqltask_deps004_task_tags.sqltask_tags,task_history_tagsBREAKING CHANGE: Existing SQLite databases must be recreated. This is acceptable as the project is pre-1.0.