fix: use distinct critcmp group names so PR benchmark diff shows two columns#77
Merged
Conversation
…columns Both the main baseline and PR results were exported under the group name "current", causing critcmp to merge them into a single column instead of a side-by-side comparison. Rename to "main" and "pr" respectively.
Contributor
Benchmark ComparisonClick to expand |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
critcmp group name (
"current"), causingcritcmp baseline.json pr.jsontomerge them into a single column instead of producing a side-by-side comparison.
"main"and the PR export group to"pr"so critcmp can diff them as two distinct columns.