The ontology tables read like a table - #540
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: WaylandYang <wayland0916@gmail.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: WaylandYang <wayland0916@gmail.com>
…othing Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: WaylandYang <wayland0916@gmail.com>
WaylandYang
force-pushed
the
fix/the-tables-paginate
branch
from
September 9, 2026 13:41
058d56c to
914ddea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three things wrong with the table view, all found in one pass.
It drew every row
916 classes, 1102 properties, 599 attributes, all built into the DOM at once. You
can feel it in the scrollbar, and only the dozen rows on screen are being read.
The rail's class tree has paginated from the start (14 per page). The tables now do
the same, using the
PagerandpageSlicealready inui/, at 50 per page. Fiftyrather than fourteen because a full-width table shows more at once.
The classes table paginates the already-flattened tree, so a page is a
contiguous run of tree order and a child is never separated from the parent above
it. The pager sits after the table rather than in a fixed footer: that area is
already a scroll region, and pinning a bar there would clip the last row.
Its skeleton was the wrong shape
The loading skeleton reused the rail's row (24px) for rows that are really 39px.
A third too short, and a column of them reads dense and wrong — visibly not the
shape of the table that is coming.
Fixed the way the rail's version already works: build it from the real
TrandTd, so the height comes from the components rather than a number someone typed.The cell also needs a full line box inside it (
.u-skel-line, one--text-bodyline-height), because a real cell holds a line of text; without it the row is
8 + 16 + 8 instead of 8 + 22 + 8. Measured after: 38.5px against the real 39px, the
half-pixel being the row border.
A skeleton's whole job is to say what shape is coming. Saying it wrong is worse
than not saying it.
Two columns of noise
The key column is gone.
accepted_answeris machine identity, not something toread, and in a table meant for scanning the library sideways — which classes have no
instances, which properties have no domain — it just restates the name on every row.
It is still in the detail panel, where one term is discussed at a time.
The filter's
/icon is gone. By convention that hints "press slash to focus",but the shortcut is only bound on the Docs page, so here it advertised a key that
does nothing. The rail's identical filter on the same page uses a magnifier; now
both do.
Checked
pnpm buildclean; style guard 46/46.1–50 of 916, 50 rows, starts at Technology51–100 of 916, starts at BefriendAction101–150 of 9161–50 of 1102, from the top1–50 of 1102🤖 Generated with Claude Code