Skip to content

Fix: change uplo to U for lapack_hegvd to be consistent with former routine #6868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mohanchen merged 2 commits into from
Jan 18, 2026
Merged

Fix: change uplo to U for lapack_hegvd to be consistent with former routine #6868

mohanchen merged 2 commits into from
Jan 18, 2026

Conversation

@Cstandardlib
Copy link
Collaborator

@Cstandardlib Cstandardlib commented Jan 17, 2026 •
edited
Loading

Linked Issue

Fix #6867

What's changed?

  • change uplo to U for lapack_hegvd to be consistent with former routine. Now GPU result is the same as CPU for ks_solver dav_subspace.

@Cstandardlib Cstandardlib mentioned this pull request Jan 17, 2026
Merged
@mohanchen mohanchen added Bugs Bugs that only solvable with sufficient knowledge of DFT Refactor Refactor ABACUS codes labels Jan 18, 2026
@mohanchen mohanchen merged commit a53930b into deepmodeling:develop Jan 18, 2026
14 checks passed
@Cstandardlib Cstandardlib deleted the tests/ds-gpu branch January 18, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees

No one assigned

Labels

Bugs Bugs that only solvable with sufficient knowledge of DFT Refactor Refactor ABACUS codes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent result of GPU/CPU dav_subspace

2 participants

@Cstandardlib @mohanchen