Fix repetition penalty forwarding in data generation - #82
Draft
Sehlani042 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--repetition-penaltythrough SGLang'sextra_bodypresence_penaltyRoot cause
generate_train_data.pymapped the CLI repetition penalty topresence_penalty. These are different sampling controls: SGLang exposesrepetition_penaltyas an extra request field, whilepresence_penaltychanges token-presence behavior. The CLI therefore silently requested a different sampling policy than the user selected.Validation
env PYTHONPATH=. uv run --with pytest --with openai pytest -q tests/test_generate_train_data.py(3 passed)uvx ruff check tests/test_generate_train_data.pyuvx ruff check --ignore BLE001 scripts/data/generate_train_data.py tests/test_generate_train_data.py(the unignored source-file scan reports three pre-existingBLE001findings outside this diff)python -m py_compilefor both changed Python filesgit diff --check origin/main...HEADAI assistance
This change was developed with Codex assistance. I reviewed the diff and validation evidence before publication.