Skip to content

feat: adding _normalize_metadata_field_name to haystack.utils#10798

Merged
davidsbatista merged 2 commits intomainfrom
feat/adding-normalize-metadata-util
Mar 12, 2026
Merged

feat: adding _normalize_metadata_field_name to haystack.utils#10798
davidsbatista merged 2 commits intomainfrom
feat/adding-normalize-metadata-util

Conversation

@davidsbatista
Copy link
Contributor

Related Issues

Proposed Changes:

  • _normalize_metadata_field_name is currently being used by 5 different document stores. Moving it to haystack.utils and later will open a PR in haystack-core-integrations to import from here.

How did you test it?

  • Added a unit test

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@davidsbatista davidsbatista requested a review from a team as a code owner March 12, 2026 09:20
@davidsbatista davidsbatista requested review from sjrl and removed request for a team March 12, 2026 09:20
@vercel
Copy link

vercel bot commented Mar 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Mar 12, 2026 9:20am

Request Review

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Mar 12, 2026
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 22994881246

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 92.861%

Totals Coverage Status
Change from base Build 22994739540: 0.001%
Covered Lines: 15661
Relevant Lines: 16865

💛 - Coveralls

@davidsbatista davidsbatista added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Mar 12, 2026
@davidsbatista
Copy link
Contributor Author

upcoming PR is here in draft mode: deepset-ai/haystack-core-integrations#2953

Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidsbatista davidsbatista merged commit c570f8a into main Mar 12, 2026
24 of 25 checks passed
@davidsbatista davidsbatista deleted the feat/adding-normalize-metadata-util branch March 12, 2026 13:59
alvinttang pushed a commit to alvinttang/haystack that referenced this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add _normalize_metadata_field_name() to haystack.utils

3 participants