Codeql improvements#919
Merged
ekharkunov merged 10 commits intodevfrom Apr 15, 2026
Merged
Conversation
…tocols (https->http)
Summary - Extender code coverage reportSummary
Coveragecom/defold/extender - 28.2%
com/defold/extender/builders - 0%
com/defold/extender/cache - 32.4%
com/defold/extender/cache/info - 100%
com/defold/extender/log - 0%
com/defold/extender/metrics - 7.4%
com/defold/extender/process - 10.4%
com/defold/extender/remote - 4.9%
com/defold/extender/services - 43.8%
com/defold/extender/services/cocoapods - 51.8%
com/defold/extender/services/data - 80.7%
com/defold/extender/tracing - 18.7%
com/defold/extender/utils - 0%
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| LOGGER.info("Using context for platform: {}", buildState.fullPlatform); | ||
| LOGGER.info("Using context for platform: {}", builder.platform); |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a95d576746
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
| return response; | ||
| } while(counter < maxRedirects); | ||
| throw new NullPointerException(String.format("Mac redirect count reached for request {}", url.toString())); |
There was a problem hiding this comment.
doRequestWithRedirects throws a NullPointerException when redirect handling fails, but its callers in SDK/mappings download paths only handle IOException. In a redirect loop or over-limit redirect chain, this runtime exception bypasses the existing retry/fallback branches and aborts the whole fetch instead of being handled like other transport failures. Returning an IOException here keeps failure behavior consistent with the surrounding error-handling logic.
Useful? React with 👍 / 👎.
| continue; | ||
| } | ||
| return response; | ||
| } while(counter < maxRedirects); |
There was a problem hiding this comment.
The loop increments counter before making the request and then checks while (counter < maxRedirects), which means a configured limit of N only allows N-1 redirects (for example, maxRedirectCount=1 allows none). This can fail valid redirect chains exactly at the configured limit and makes the maxRedirectCount setting behave unexpectedly.
Useful? React with 👍 / 👎.
britzl
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
includeflagsdebugSourcePath