fix(repair): 补齐 OrderService.calculateUnitPrice 的 quantity 参数校验#18
Open
deibudei wants to merge 1 commit into
Open
fix(repair): 补齐 OrderService.calculateUnitPrice 的 quantity 参数校验#18deibudei wants to merge 1 commit into
deibudei wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto Repair
Session:
pr-quantity-20260504-120909Plan
RepairPlan[repairTarget=补齐 OrderService.calculateUnitPrice 的 quantity 参数校验, rootCauseHypothesis=quantity 为 0 时直接执行除法，触发 ArithmeticException，未做参数校验。, suspectedFiles=[target-service/src/main/java/com/example/targetservice/service/OrderService.java, target-service/src/main/java/com/example/targetservice/controller/OrderController.java, target-service/src/test/java/com/example/targetservice/service/OrderServiceTest.java, target-service/src/test/java/com/example/targetservice/controller/OrderControllerTest.java], steps=[在 OrderService.calculateUnitPrice 方法开头拒绝 quantity <= 0，抛出包含 quantity 的 IllegalArgumentException。, 保留合法入参的 totalCents / quantity 计算逻辑。, 运行 target-service 测试覆盖 service 与 controller 行为。], testCommand=mvn -pl target-service test]
Review
Patch is limited to target-service and tests pass.