fix(repair): 修复 InventoryService.deduct 的并发竞态条件#23
Open
deibudei wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto Repair
Session:
pr-race-20260506-002410Plan
RepairPlan[repairTarget=修复 InventoryService.deduct 的并发竞态条件, rootCauseHypothesis=deduct 方法先读后写未加锁，多线程同时读到相同库存并通过校验后扣减，导致超卖。, suspectedFiles=[target-service/src/main/java/com/example/targetservice/service/InventoryService.java, target-service/src/main/java/com/example/targetservice/repository/InventoryRepository.java, target-service/src/test/java/com/example/targetservice/service/InventoryServiceConcurrencyTest.java], steps=[在 InventoryRepository 新增原子扣减方法 deductStock(sku, quantity)，使用 ConcurrentHashMap.compute 保证读-校验-写原子性。, 重构 InventoryService.deduct 调用 repository.deductStock，移除本地非原子逻辑。, 运行 InventoryServiceConcurrencyTest 验证并发扣减不再超卖。], testCommand=mvn -pl target-service test]
Review
Patch is limited to target-service and tests pass.