fix: make GitHub PR-description ticket selection deterministic#3
Open
dellch wants to merge 1 commit into
Open
Conversation
extract_ticket_links_from_pr_description() accumulated issue URLs in a set, then applied the MAX_TICKETS cap by slicing list(set), which picks an arbitrary subset that can vary between runs. Track URLs in first-seen order while de-duplicating (mirroring find_jira_tickets), so the cap keeps a stable, predictable subset. Co-Authored-By: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extract_ticket_links_from_pr_description()accumulates GitHub issue URLs in aset, then enforces the 3-ticket cap by slicinglist(github_tickets)[:3]. Because sets are unordered, the chosen subset can differ between runs, so which tickets get used for review context is nondeterministic when a PR description references more than 3 issues.Fix
Track URLs in first-seen order while de-duplicating (a
seenset plus an ordered list), then apply the cap by slicing the ordered list. Selection is now stable and predictable.Notes
Test plan
pytest tests/unittest/test_extract_issue_from_branch.pyCo-Authored-By: Claude