test: add VersionTarget::AtTimestamp and IncrementalFrom to TestTableBuilder#2652
Open
DrakeLin wants to merge 3 commits into
Open
test: add VersionTarget::AtTimestamp and IncrementalFrom to TestTableBuilder#2652DrakeLin wants to merge 3 commits into
DrakeLin wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2652 +/- ##
==========================================
- Coverage 88.71% 88.70% -0.01%
==========================================
Files 193 193
Lines 63257 63269 +12
Branches 63257 63269 +12
==========================================
+ Hits 56116 56125 +9
- Misses 4966 4969 +3
Partials 2175 2175 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
@DrakeLin does this need review? |
scottsand-db
reviewed
Jun 4, 2026
scottsand-db
left a comment
scottsand-db
left a comment
Collaborator
There was a problem hiding this comment.
Some comments / questions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Adds two new
VersionTargetvariants to theTestTableBuilderframework and wires them into the default cross-product sweep:AtTimestamp(i64)- timestamp time travel viahistory_manager::latest_version_as_of.IncrementalFrom { from: u64, to: u64 }- build a base snapshot atfrom, then incrementally update to a specific targetto(vsIncrementalToLatestwhich always goes to latest).Two canonical sweep rows are added:
version_at_timestamp_max()usesi64::MAXso the call resolves to the latest version uniformly across ICT-enabled and file-modification-timestamp tables.version_incremental_from_mid_to_pre_latest()goes from mid tolatest - 1to exercise the partial-replay path to a non-latest target.Tracking issue: #2526
How was this change tested?
test_version_targetsintest-utils/src/table_builder.rsextended with the two new variants.