parse table metadata.configuration as TableProperties#453
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
New
TablePropertiesstruct parses theMetadataaction'sconfigurationinto a strongly-typed configuration struct. Instead of previously manually querying specific keys (e.g. checking ColumnMapping key) we can leverage the configuration to appropriately handle DVs, column mapping, etc. in a structured manner.Pragmatically, the changes are:
TablePropertiesstruct along with newSnapshot::get_table_properties()APIa. Note that every field is optional and additionally there is an
unknown_propertiesfield which includes a hashmap of all fields that did not parse to a known table property.table_propertiesmodule including deserialization submodule to implement functions to deserialize the fields ofTablePropertiesFuture work
TablePropertiesfields with protocol links #519TablePropertiesparsing performance #535This PR affects the following public APIs
TablePropertiesandSnapshot::get_table_propertiesAPIHow was this change tested?
new ut
Credit: @roeap for the original PR which this is based on #222