Refactor js #17

Activity

1. hampterhub commented on Oct 9, 2018

   

   hampterhub

   on Oct 9, 2018

   Contributor

   More actions

   agreed, it can be improved a lot and there is stuff like the animationRef that can be removed. not sure about classes, if you still want to implement IE then best we can do are prototypes or modules.

   If IE isnt an issue then the only thing i have to comment on would be that i think the specific animation functions wont fit well as a class but maybe we can abstract it to a set of instructions like the svgblueprint
2. thumbnail commented on Oct 9, 2018

   

   thumbnail

   on Oct 9, 2018

   MemberAuthor

   More actions

   Since we add browserify / babelify in #14, it gets transpiled to es2015 anyway, so we can use (most of) the features afaik.
3. thumbnail

   added

   enhancementNew feature or requestNew feature or request

   on Oct 9, 2018