Skip to content

BeautifulSoup is replaced with regexp#5

Open
rantanevich wants to merge 1 commit into
demian-wolf:masterfrom
rantanevich:langs
Open

BeautifulSoup is replaced with regexp#5
rantanevich wants to merge 1 commit into
demian-wolf:masterfrom
rantanevich:langs

Conversation

@rantanevich
Copy link
Copy Markdown

Hi!
I've made a few changes:

  • add .gitignore file
  • throw BeautifulSoup away and use simple regexp

Could you shed some light on the get_examples method of ReversoContextAPI?

@demian-wolf
Copy link
Copy Markdown
Owner

Thank you very much for your work!

Could you shed some light on the get_examples method of ReversoContextAPI?

Currently, however, neither get_examples or get_translations work (see issue #6). It looks like there were drastic changes on the website, so it might be even necessary to replace some API calls via requests with parsing HTML via BeautifulSoup.

When I have time, I'm going to figure out the cause of the problem, and depending on that I will decide whether to merge this PR or not.

@rantanevich
Copy link
Copy Markdown
Author

Sure. I would still suggest to use request session to reuse a single connection instead of creating a short-live connection for each request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants