Skip to content

Addon some times adds broken matches right after normal matches #2

Description

@johannesklev

Not sure how to reproduce. However, addon some times adds matches with Duration close or equal to 0s right after an actual match.
Before saving a new row of data, it could be smart to check the Duration. Because of the wait time, no arena match can be below 1 minute.
If the match duration is below 1 minute, the addon could make some comparisons to the game before it, and delete if it's a duplicate entry.
image
image
Pasted above are two entries that easily could have been filtered out and thrown away. (Note that the Duration is not always 0s)

Expected behaviour:
Each item on the match list is a unique match.

Suggested fix:
Set a unique "entry ID" at the start of each match, and only add entries to the list if the ID is unique.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions