dpd-dashboard theme changed, file editor added, screenshots#13
Open
moorthi07 wants to merge 11 commits intodeployd:masterfrom
Open
dpd-dashboard theme changed, file editor added, screenshots#13moorthi07 wants to merge 11 commits intodeployd:masterfrom
moorthi07 wants to merge 11 commits intodeployd:masterfrom
Conversation
Contributor
|
I would suggest publishing this as a new separate fork, maybe name it The scope of the changes here are too big for dpd-dashboard. This is not something most people will need. |
Member
Author
|
@andreialecu can you be more specific on which feature you think not in the scope of dashboard. Because we have been discussing more than a year to revamp and redo dpd-dashboard. This PR has made it look better. One more minor fix done in this PR is, 'Add resource dialogbox placeholder name jumping issue' |
Member
Author
|
The file editor is pulled out now. So, new theme for dashboard and a fix for 'add collection' dialog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dpd-dashboard theme changed, file editor added, screenshots.
This leads dpd-dashboard a full scale Deployd IDE
Note: The merge diff shows lots of differences - mostly its the visualcode editor formatting for js files.
For example, ( a comma - ',' in the prefix is moved to end of line)
, ejs = require('ejs')
is corrected to,
ejs = require('ejs'),