Updates to index.html#138
Open
OneRadRedDad wants to merge 8 commits into
Open
Conversation
General grammar changes; fixed nested list in help window's Character Sheet section; replaced ol in help window's Action section with a dl; added a link to Google's Firebase Firestore; added some b tags when referencing buttons in the app
If it ain't the consequences of my own actions. Trying to get back into this project after sitting it aside for a while, and I messed up git a little. This is me trying to correct it while making commits to derikb's original project.
Owner
|
Hey @OneRadRedDad thanks for the PR. Could you add an issue to the Repo describing what you were changing/fixing. I like to keep any commits/merges tied to issue numbers if they are more than dependency updates and the like. |
Author
Sure! Do I add the issue to my repo or yours? Still pretty new to github, sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-created pull request after renaming branch