Redesign login form (eos-breeze style) and eliminate preview/theme duplication#6
Merged
Redesign login form (eos-breeze style) and eliminate preview/theme duplication#6
Conversation
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
LoginForm: remove username field (uses defaultUsername directly), add password + small icon login button in a horizontal row, restyle password field with dark slate inset background. Main.qml: move PowerBar from footer to directly below login form, centered horizontally. Preview architecture: inject mock SDDM context properties (sddm, config, userModel, sessionModel, keyboard) from Python via setContextProperty(), matching how the real SDDM greeter works. This lets the Loader load the theme's Main.qml directly — eliminating ThemeLayout.qml and the duplicated layout logic that had to be kept in sync. - preview-host.py: add MockSddm, MockConfig (reads theme.conf), MockUserModel, MockSessionModel, MockKeyboard classes - Preview.qml: reduced to thin window shell + Loader + overlay - preview.sh: also symlinks Main.qml, passes theme dir to Python host - lint-qml.sh: use Python host for runtime type-error check - Delete preview/ThemeLayout.qml 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Comprehensive rewrite covering: - Updated preview architecture (Python context properties, no ThemeLayout) - Full SDDM context property reference table - Key file descriptions for all theme and preview files - QML guidelines: graphical effects, inset borders, Component.onCompleted pitfall, color functions, focus management, common patterns - PyQt6 guidelines: GC/object lifetime, configparser casing, file URL paths, writable properties, QAbstractListModel roles - Context7 documentation references for Qt 6 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
userModel.lastUserdirectly), add password + small icon login button in a horizontal row, restyle password field with dark slate inset background, move power buttons directly below the login formpreview-host.py) viasetContextProperty()— the same mechanism real SDDM uses — so the Loader loads the theme'sMain.qmldirectly. EliminatesThemeLayout.qmland the duplicated layout logic that had to be kept in sync. Any theme inthemes/now works with the preview out of the box.Test plan
./scripts/lint-qml.sh— passes static analysis and runtime type-error check./scripts/preview.sh— preview window shows background, clock, password field with inline login button, power buttons centered below, session selector in footertestin preview — mock login succeedsthemes/default/contain theme-specific layout logic🤖 Generated with Claude Code