Skip to content
This repository was archived by the owner on Oct 23, 2025. It is now read-only.

Based on PR#7#8

Open
desdo09 wants to merge 17 commits into
masterfrom
feature/modernui
Open

Based on PR#7#8
desdo09 wants to merge 17 commits into
masterfrom
feature/modernui

Conversation

@desdo09
Copy link
Copy Markdown
Owner

@desdo09 desdo09 commented Nov 3, 2024

@EphraimElgrabli
Please add your comments here :)

@EphraimElgrabli
Copy link
Copy Markdown

hi, this is my comment :)

@EphraimElgrabli
Copy link
Copy Markdown

I've documented all the changes made in the markdown. In essence, I've completely redesigned the entire homepage of Moodle, replacing the need to open a popup. Instead, it now displays all the necessary information, including the weekly calendar from the Levnet (which has been reported to have some bugs, and I'm currently investigating them). I've also ensured that all ongoing homework tasks are correctly scraped from the new version of Moodle and presented in a more organized and visually appealing manner. Additionally, I've updated certain elements from the old version that will no longer receive support in the future, such as the background.html page instead of importing everything directly from the manifest. Lastly, I've redesigned the logo of Machon because, in my opinion, the current one appears outdated. If you'd like to see a screenshot, feel free to ask.

@desdo09
Copy link
Copy Markdown
Owner Author

desdo09 commented Nov 3, 2024

@EphraimElgrabli
Great work! I've reviewed your documentation and tested the extension. Overall, it’s a nice job, but I have a few questions and suggestions:

Removal of Popup Overview: Could you clarify why the popup displaying all homework was removed? This popup is essential for users, as it provides a quick overview of upcoming assignments and events.

Homework Alarm Configuration in Settings: I noticed the homework alarm configuration option was removed from the settings. Can you explain the reasoning behind this? This feature was helpful for reminding students about deadlines.

Course Selection in Settings: The options for selecting specific courses for the "Homeworks" and "Courses" tabs were also removed. Could you share more about this decision? Filtering by course allows users to manage their workload more effectively.

In conclusion, while I appreciate the updates made to reflect Moodle’s recent changes, retaining key features like the homework popup and course selection is important to maintain the extension’s core functionality. Also, considering that Moodle’s interface might change again in the future, it would be beneficial to keep these functionalities adaptable to minimize the need for extensive reconfiguration.

@desdo09
Copy link
Copy Markdown
Owner Author

desdo09 commented Nov 3, 2024

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants