This repository was archived by the owner on Sep 28, 2023. It is now read-only.
Adding default value to follow redirect#10
Open
luanpotter wants to merge 1 commit into
Open
Conversation
… to use in general.
ferwasy
suggested changes
Jun 8, 2018
ferwasy
left a comment
ferwasy
left a comment
Contributor
There was a problem hiding this comment.
I think that these changes are OK. But I would create a different test class for the case of "not follow redirect" SparkServer, so it can be a @ClassRule and not created inside the test method (notice that the server instances are not stopped).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding default value to follow redirect, in order to make API simpler to use in general.
It can be set on the constructor, and it is true by default.
Every method gets an overload that doesn't require the
followRedirectflag and uses the default value provided.I think in most use cases all the requests in the tests will use the same value for this, so this change make the API a bit simpler to use in some cases.
Please let me know what you think!
I've also added a test to verify this case.