[PL] Previous version of atlas crashed when using numpy float64 types…#156
Open
pippinlee wants to merge 2 commits into
Open
[PL] Previous version of atlas crashed when using numpy float64 types…#156pippinlee wants to merge 2 commits into
pippinlee wants to merge 2 commits into
Conversation
… with log_metric(), this test case ensures that is no longer the case #127
mohammedri
approved these changes
May 15, 2020
…a new release. Cypress tests will then run against latest master on uat-atlas pipeline that contains fix for log_metric with numpy values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, having a numpy float64float64 type with log_metric() would cause atlas to crash. This test confirms stability when using this numpy type.
Note: the following types are still considered invalid:
type(np.random.rand(1)[0])np.array([1,2,3,4])np.ndarray([1,2,3])Ticket link:
#127