Route YouTube command through destiny.gg public API#176
Merged
Conversation
Route the YouTube service through the website's /api/info/videos and /api/info/stream endpoints instead of googleapis. Drops the YOUTUBE_API_KEY/YOUTUBE_CHANNEL config and shares dggApi.baseUrl across both services.
getChannelStatus and getActiveLiveBroadcastsVideoId had no production callers — drop them along with their tests and stream fixtures.
Both services now hit the same destiny.gg base URL with no special state, so collapse the video methods onto DggApi and delete the standalone YouTube service.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/info/videosendpoint, dropping theYOUTUBE_API_KEYandYOUTUBE_CHANNELconfig.getChannelStatusandgetActiveLiveBroadcastsVideoIdmethods (no production callers).DggApiand deleteslib/services/youtube.js— both services now share the samedggApi.baseUrl.Test plan
npm test— 194 passing, 0 failingnpm run lint— clean!youtubeagainst a test chat and confirm the message format ("<title>" posted <relative time> https://youtu.be/<id>)!liveto confirm thedggApi.baseUrlrename didn't regress the live command