Feature: #3 - Added User Preference to Disable/Enable Click to Play/Pause#21
Merged
11k merged 3 commits intoApr 23, 2026
Conversation
… added to settings menu
TuringQuantrix
changed the title
TuringQuantrix
changed the title
TuringQuantrix
commented
Feb 19, 2026
| isPlaying, | ||
| handlePlayPause, | ||
| showControls, | ||
| clickToPlayPause, |
Contributor
Author
There was a problem hiding this comment.
The prop drilling here is not ideal but needed for the container and switch to share the same piece of state.
We could avoid this with a state library but that's likely overkill. Or using providers but that would break the current pattern we have for preferences.
Collaborator
|
Can you make the menu wider so the "Pause on Click" text doesn't wrap? I don't like the way it looks when it's two lines. |
Contributor
Author
Done. Made the dropdown width dynamic with a min width of the original width (180px) |
11k
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't love the label "Pause on Click". I'm open to suggestion for better copy or alternatively making the menu wider so the text doesn't wrap.
I tested and confirmed this option does not impact clicking the play/pause button or the tapping the space bar.