Skip to content

feat: add "Maximum" quality option#24

Merged
11k merged 2 commits into
mainfrom
feat/max-quality-option
May 29, 2026
Merged

feat: add "Maximum" quality option#24
11k merged 2 commits into
mainfrom
feat/max-quality-option

Conversation

@ohslyfox

Copy link
Copy Markdown
Contributor

Motivation

When a user selects a specific quality (e.g. 1080p60) and then swaps to a stream that doesn't offer that exact option (e.g. only has 1080p), the saved quality no longer matches any available option. This causes the player to silently fall back to Auto

Summary

  • Add passthrough quality option that resolves to the max bitrate quality
  • Add defensive sort on quality response payload to guarantee functionality
    • Example payload:
{
  "name": "1080p60",
  "group": "chunked",
  "codecs": "avc1.64002A,mp4a.40.2",
  "bitrate": 7075829,
  "width": 1920,
  "height": 1080,
  "framerate": 60,
  "isDefault": true,
  "variantSource": "source",
  "variantId": "",
  "attributes": {
    "Pipeline": "",
    "SourceType": ""
  },
  "sourceGroups": []
}
2026-05-18.13-58-38.mp4

@11k 11k added the enhancement New feature or request label May 25, 2026
@11k

11k commented May 25, 2026

Copy link
Copy Markdown
Collaborator

I don't like that the main menu displays the active quality (e.g., "1080p60") rather than "Maximum" when max quality is selected. It creates a situation where the user doesn't know they have max quality selected unless they open the quality settings menu. Additionally, I prefer the word "Best" to describe the best possible quality over "Maximum".

Can you address these issues?

@ohslyfox

Copy link
Copy Markdown
Contributor Author

It creates a situation where the user doesn't know they have max quality selected unless they open the quality settings menu.

I considered this, but the alternative would display "Maximum" with no indication of what the actual quality selection is.

Agreed with "Best" terminology, maybe we can include the quality in parenthesis like Best (1080p60) since "Best" saves on width space. What do you think?

@11k

11k commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Works for me, go for it!

@ohslyfox

Copy link
Copy Markdown
Contributor Author
Screenshot 2026-05-27 115937 Screenshot 2026-05-27 115944

@11k 11k merged commit 3a34548 into main May 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants