feat: Add Volume Scrolling#25
Open
ponderouspawn wants to merge 5 commits into
Open
Conversation
ponderouspawn
force-pushed
the
feat/add-volume-scroll
branch
from
bc1002f to
49425e2
Compare
Collaborator
|
I'd prefer that this setting isn't configurable. Just go ahead and hardcode a sensible value for scroll step. It's also not obtrusive enough that users would want to disable it, so we can leave it always enabled. |
Author
User preference removed. Laptop trackpad scrolls will change the volume by 1 unit and mouse wheel scrolls 5 units. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ContainercomponentI needed to use prop drilling. I don't mind writing a follow up pr that moves all the state to react-redux or contexts.
Screen.Recording.2026-05-20.at.10.41.45.PM.mov