S50: expose dlna.allowed_cidrs + dlna.restrict_to_lan (server-settings schema) — v0.45.0 - #34
Merged
Conversation
…to_lan (S50, updates.md #35) Surface the two DLNA inbound-allowlist keys consumed by phlix-server's new DlnaAllowlistMiddleware in the generic admin Settings page: - dlna.allowed_cidrs (array<string>, default []) — CIDR allowlist for the DLNA browse/stream endpoints; an empty list is NEVER allow-all. - dlna.restrict_to_lan (boolean, default true) — LAN-only default posture when the allowlist is empty/unmatched. Both are advanced-tier, restart:false (the middleware reads them live). Needs a release + re-vendor in phlix-server (which then bumps the two schema lock-in tests: key count and the hand-written type map). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…llowlist keys Completes the release commit for the dlna.allowed_cidrs + dlna.restrict_to_lan schema keys (added in 7e44dd2). Follows the established per-release convention: - src/Version.php: VERSION 0.44.0 -> 0.45.0 (additive schema change = minor bump, matching every prior schema release; there are no patch releases in this repo). - tests/Schema/ServerSettingsSchemaTest.php: register the two new keys in propertyProvider() (types array + boolean) and bump the exact property-key count assertion 70 -> 72. - CHANGELOG.md: 0.45.0 entry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #34 +/- ##
=========================================
Coverage 81.29% 81.29%
Complexity 414 414
=========================================
Files 50 50
Lines 1160 1160
=========================================
Hits 943 943
Misses 217 217
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two keys to
schemas/server-settings.schema.jsonso the admin settings UI can render/edit the DLNA IP allowlist (S50 / updates.md #35):dlna.allowed_cidrs—array, default[](an empty list is NEVER allow-all)dlna.restrict_to_lan—boolean, defaulttrueBoth are already consumed server-side by
DlnaAllowlistMiddleware(read live viaSettingsRepository::getEffective()againstconfig/dlna.php); the schema entry only makes them render in the settings UI. Bothtier: advanced,group: subsystem,restart: false.Release bits (per the established per-release convention):
src/Version.php:0.44.0→0.45.0(additive schema change = minor bump; this repo has no patch releases).tests/Schema/ServerSettingsSchemaTest.php: register the two keys inpropertyProvider()(typesarray/boolean) + bump the exact key-count assertion70→72.CHANGELOG.md:0.45.0entry.Verification (local):
phpunit1025 tests / 83028 assertions OK;phpstan analyseno errors;phpcs --standard=PSR12 src/clean.🤖 Generated with Claude Code