Skip to content

docs: correct file:line citations for pubnet guards - #169

Open
soladayo21963-coder wants to merge 1 commit into
determined-001:mainfrom
soladayo21963-coder:main
Open

docs: correct file:line citations for pubnet guards#169
soladayo21963-coder wants to merge 1 commit into
determined-001:mainfrom
soladayo21963-coder:main

Conversation

@soladayo21963-coder

Copy link
Copy Markdown

Summary

The DEFAULT_SELLER_WALLET, SERVER_SIGNING_SECRET, and JWT_SECRET boot-time guards do not live in env.ts — they live in apps/api/src/services/container.ts inside resolveSellerKeypairOrWallet() (:386), resolveServerSigningKeypair() (:489), and resolveJwtSecret() (:512). The OFFRAMP / USDC issuer / anchor-URL guards are correctly in env.ts (lines 114–142).

Both docs/MAINNET.md and docs/RUNBOOK.md cited env.ts for all guards, sending anyone verifying or changing a safety check to the wrong file — exactly the wrong outcome for docs read under pressure.

Changes

docs/MAINNET.md

  • Rewrote the "Read this first" paragraph to name both files with line hints: env.ts at module load (lines 114–142) for OFFRAMP/USDC/anchor-URL, and container.ts inside createContainer() for DEFAULT_SELLER_WALLET (:386), SERVER_SIGNING_SECRET (:489), and JWT_SECRET (:512).
  • Updated the test-coverage footnote to clarify env-mainnet-guards.test.ts only covers the env.ts guards; the container.ts guards are not yet covered by a dedicated test file.

docs/RUNBOOK.md

  • JWT_SECRET and SERVER_SIGNING_SECRET rows: added "Process will not boot on public network" with exact function+line citations (container.ts:512 / :489).
  • Added a missing DEFAULT_SELLER_WALLET row — it was boot-fatal on pubnet via container.ts:386 but absent from the required-variables table entirely.
  • Extended the outage-lesson paragraph to note that the same "forgot to add to render.yaml" mistake applies equally to the container.ts guards, naming all three with their line numbers.

What was tested

All changed references were verified by reading the source files directly:

  • container.ts:386throw new Error("Set DEFAULT_SELLER_WALLET...")
  • container.ts:489throw new Error("Set SERVER_SIGNING_SECRET...")
  • container.ts:512throw new Error("Set JWT_SECRET...")
  • env.ts lines 114–142 — the OFFRAMP/USDC/anchor-URL guardrail block

No functional code changes.

Closes #166

The DEFAULT_SELLER_WALLET, SERVER_SIGNING_SECRET, and JWT_SECRET
guards do not live in env.ts — they live in container.ts inside
resolveSellerKeypairOrWallet() (:386), resolveServerSigningKeypair()
(:489), and resolveJwtSecret() (:512) respectively. The OFFRAMP,
USDC issuer, and anchor-URL guards are correctly in env.ts (:114-142).

- MAINNET.md: rewrite the 'Read this first' paragraph to name both
  files with line hints; update the test-coverage note to clarify
  env-mainnet-guards.test.ts only covers the env.ts guards
- RUNBOOK.md: add 'Process will not boot on public network' + exact
  container.ts function/line citations to the JWT_SECRET and
  SERVER_SIGNING_SECRET rows; add DEFAULT_SELLER_WALLET as a boot-
  fatal row (was missing entirely); extend the outage note to flag
  that the same deploy-without-render-yaml mistake is possible in
  container.ts for all three pubnet-required keys

Closes determined-001#166
@drips-wave

drips-wave Bot commented Aug 28, 2026

Copy link
Copy Markdown

@soladayo21963-coder Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

@soladayo21963-coder is attempting to deploy a commit to the determined's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8.12 - Docs attribute three boot guards to the wrong file

1 participant