docs: correct file:line citations for pubnet guards - #169
Open
soladayo21963-coder wants to merge 1 commit into
Open
docs: correct file:line citations for pubnet guards#169soladayo21963-coder wants to merge 1 commit into
soladayo21963-coder wants to merge 1 commit into
Conversation
The DEFAULT_SELLER_WALLET, SERVER_SIGNING_SECRET, and JWT_SECRET guards do not live in env.ts — they live in container.ts inside resolveSellerKeypairOrWallet() (:386), resolveServerSigningKeypair() (:489), and resolveJwtSecret() (:512) respectively. The OFFRAMP, USDC issuer, and anchor-URL guards are correctly in env.ts (:114-142). - MAINNET.md: rewrite the 'Read this first' paragraph to name both files with line hints; update the test-coverage note to clarify env-mainnet-guards.test.ts only covers the env.ts guards - RUNBOOK.md: add 'Process will not boot on public network' + exact container.ts function/line citations to the JWT_SECRET and SERVER_SIGNING_SECRET rows; add DEFAULT_SELLER_WALLET as a boot- fatal row (was missing entirely); extend the outage note to flag that the same deploy-without-render-yaml mistake is possible in container.ts for all three pubnet-required keys Closes determined-001#166
|
@soladayo21963-coder Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@soladayo21963-coder is attempting to deploy a commit to the determined's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
DEFAULT_SELLER_WALLET,SERVER_SIGNING_SECRET, andJWT_SECRETboot-time guards do not live inenv.ts— they live inapps/api/src/services/container.tsinsideresolveSellerKeypairOrWallet()(:386),resolveServerSigningKeypair()(:489), andresolveJwtSecret()(:512). The OFFRAMP / USDC issuer / anchor-URL guards are correctly inenv.ts(lines 114–142).Both
docs/MAINNET.mdanddocs/RUNBOOK.mdcitedenv.tsfor all guards, sending anyone verifying or changing a safety check to the wrong file — exactly the wrong outcome for docs read under pressure.Changes
docs/MAINNET.mdenv.tsat module load (lines 114–142) for OFFRAMP/USDC/anchor-URL, andcontainer.tsinsidecreateContainer()forDEFAULT_SELLER_WALLET(:386),SERVER_SIGNING_SECRET(:489), andJWT_SECRET(:512).env-mainnet-guards.test.tsonly covers theenv.tsguards; thecontainer.tsguards are not yet covered by a dedicated test file.docs/RUNBOOK.mdJWT_SECRETandSERVER_SIGNING_SECRETrows: added "Process will not boot on public network" with exact function+line citations (container.ts:512/:489).DEFAULT_SELLER_WALLETrow — it was boot-fatal on pubnet viacontainer.ts:386but absent from the required-variables table entirely.render.yaml" mistake applies equally to thecontainer.tsguards, naming all three with their line numbers.What was tested
All changed references were verified by reading the source files directly:
container.ts:386—throw new Error("Set DEFAULT_SELLER_WALLET...")container.ts:489—throw new Error("Set SERVER_SIGNING_SECRET...")container.ts:512—throw new Error("Set JWT_SECRET...")env.tslines 114–142 — the OFFRAMP/USDC/anchor-URL guardrail blockNo functional code changes.
Closes #166