5.12 - Fix nested <html> document in receipt not-found page - #176
Open
Otfrugger wants to merge 1 commit into
Open
5.12 - Fix nested <html> document in receipt not-found page#176Otfrugger wants to merge 1 commit into
Otfrugger wants to merge 1 commit into
Conversation
apps/web/app/r/[reference]/page.tsx's catch branch returned its own <html><body> wrapper from inside the root layout, which already supplies both — invalid nested-document markup, causing hydration warnings. Every other not-found branch in the app (e.g. apps/web/app/pay/[id]/page.tsx) returns a bare <main> fragment; this one now matches. Checked the rest of apps/web/app for the same shape (grep -rn '<html') — no other occurrence outside the root layout.
|
@Otfrugger Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@Otfrugger is attempting to deploy a commit to the determined's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #158
Summary
apps/web/app/r/[reference]/page.tsx's catch branch returned its own<html><body>wrapper from inside the root layout (apps/web/app/layout.tsx), which already supplies both — invalid nested-document markup, causing hydration warnings and undefined cross-browser behavior for anything depending on document structure.Removed the
<html>/<body>wrapper, leaving the bare<main>fragment — matching every other not-found branch in the app (e.g.apps/web/app/pay/[id]/page.tsx's unreachable-API branch).Checked the rest of
apps/web/appfor the same shape:grep -rn "<html" apps/web/appOnly
apps/web/app/layout.tsx(the root layout itself) matches now — no other occurrence.Verification
grep -rn "<html" apps/web/appthat no page outside the root layout emits<html>anymore.<html><body>wrapper and dedenting the existing<main>fragment, no logic touched), but please do a quick visual check before merging.