fix: add auth + cleanup to synthetic uptime check (issue 8.9 / #163) - #181
Open
Appsoft1000 wants to merge 1 commit into
Open
fix: add auth + cleanup to synthetic uptime check (issue 8.9 / #163)#181Appsoft1000 wants to merge 1 commit into
Appsoft1000 wants to merge 1 commit into
Conversation
…ined-001#163) The synthetic create-link check in scripts/uptime-check.mjs POSTs to /links with no auth header. Since seller auth landed in 6.x, POST /links requires a bearer token, so the check has been returning 401 — a permanent false negative sitting next to two real checks. Changes: - Read UPTIME_API_KEY from env and send as Bearer token in the synthetic link check. - After creating a link, cancel it via POST /links/:id/cancel so synthetic rows no longer accumulate in the database. - Improve the error message when UPTIME_API_KEY is missing (clear guidance instead of a cryptic 401). - Inject UPTIME_API_KEY from repo secrets in the GitHub Actions workflow. - Add a prominent "Last regenerated" timestamp to docs/STATUS.md so a stale page reads as stale instead of green. - Extract testable check functions into scripts/lib/uptime-check.ts. - Add scripts/uptime-check.test.ts: 11 unit tests against a mocked API covering auth, error handling, cleanup, and timeout. - docs/STATUS.md updated to show its staleness. Closes determined-001#163 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@Appsoft1000 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@Aycode01 is attempting to deploy a commit to the determined's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The synthetic create-link check in scripts/uptime-check.mjs POSTs to
/links with no auth header. Since seller auth landed in 6.x, POST
/links requires a bearer token, so the check has been returning 401 —
a permanent false negative sitting next to two real checks.
Changes:
synthetic link check.
synthetic rows no longer accumulate in the database.
guidance instead of a cryptic 401).
workflow.
a stale page reads as stale instead of green.
API covering auth, error handling, cleanup, and timeout.
Closes #163