Indi scanner - #80
Open
gnthibault wants to merge 9 commits into
Open
Conversation
Collaborator
|
please add swig dependency into readme |
deufrai
force-pushed
the
develop
branch
2 times, most recently
from
April 30, 2020 07:05
643d813 to
3fffe27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Guys
Here is what is needed for the PR to make sense:
@deufrai check the config file, and see that I added 3 parameters (getters, setters) for remote_host remote_port and device_name.
This needs to be routed to the UI (I don't know how to do that)
@gehelem If you are willing to test this out, just change the default value inside the config file by hand, to change the CCD Simulator string by your actual indi camera name (can be seen through kstars).
Apart from that I am pretty happy about that feature, discussed quite a while ago. Most of the credit goes to @deufrai that made it so convenient to add a new scanner class.