feat(contracts): add storage key collision detector and CI workflow - #1
Open
dev-fatima-24 wants to merge 2 commits into
Open
feat(contracts): add storage key collision detector and CI workflow#1dev-fatima-24 wants to merge 2 commits into
dev-fatima-24 wants to merge 2 commits into
Conversation
Closes Nova-reward#150 - Add integration tests verifying DataKey and StorageKey isolation across contracts - Add scripts/check-storage-keys.sh to check CONTRACT_PREFIX namespacing and run collision tests - Add GitHub action workflow for automated CI checking - Document key namespacing strategy in docs/storage-namespacing.md - Add Makefile shortcut check-storage-keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves Nova-reward#150 by implementing automated multi-contract storage key collision detection, storage namespacing verification, and CI automation for InvoiceFi smart contracts on Stellar.
Key Changes
contracts/integration-tests/tests/storage_key_collision_test.rsto verify that allDataKeyandStorageKeyvariants acrossaccess-control,invoice,financing-pool, andsettlementproduce unique raw payloads and preserve storage isolation in a shared environment context../scripts/check-storage-keys.shand addedmake check-storage-keysshortcut to dynamically enumerate contract prefixes and run storage tests..github/workflows/storage-collision-check.ymlto automatically enforce storage key collision checks on PRs and pushes.(Symbol, DataKey)indocs/storage-namespacing.mdand updatedREADME.md.Verification
Ran
./scripts/check-storage-keys.shandcargo test -p integration-tests- all tests pass cleanly.Closes Nova-reward#150